Repository navigation
fix: Copilot review for #100 (min_max, bench docs, GooseFS, FFI) - #102
Merged
Merged
Conversation
…I docs - Return VortexResult unsupported-type error for Union min_max (no todo!/panic) - Document 2.5B-row three-column vortex SQL bench + range query - Expose GoosefsStore on vortex.file.open / _lib/file.pyi like CosStore - Restore vx_session_clone ownership/lifecycle note for generated C API docs
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The generated FFI header is stale, the benchmark description is inaccurate, and Union error behavior lacks regression coverage.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Open (3)
What changed in this PR
Addresses four unresolved review findings from PR #100 across aggregation, benchmarks, Python bindings, and FFI documentation.
Changes:
- Replaces Union
min_maxpanic with an unsupported-type error. - Documents benchmark scale and exposes
GoosefsStoreto file APIs. - Clarifies cloned FFI session ownership.
Checks: Review only; no tests executed.
| File | Description |
|---|---|
vortex-array/src/aggregate_fn/fns/min_max/mod.rs |
Handles unsupported Union aggregation without panicking. |
vortex-bench/sql/vortex/README.md |
Documents benchmark data and range query. |
vortex-python/python/vortex/file.py |
Adds GoosefsStore to the public file API annotation. |
vortex-python/python/vortex/_lib/file.pyi |
Adds GoosefsStore to the native stub. |
vortex-ffi/src/session.rs |
Documents cloned-session ownership. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+37
to
+39
| /// Clone a Vortex session, returning an owned copy. | ||
| /// | ||
| /// The caller is responsible for freeing the session with [`vx_session_free`]. |
Comment on lines
+420
to
+421
| Canonical::Union(_) | ||
| | Canonical::Struct(_) |
Comment on lines
+15
to
+16
| - [`2_sum-range.sql`](./2_sum-range.sql): a range filter on `id` that should prune most | ||
| zone maps and only fully decode the two zones that overlap the bounds. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses the 4 unresolved Copilot threads on #100.
min_max: return unsupported-typeVortexResulterror (notodo!/panic)GoosefsStoreonvortex.file.open/_lib/file.pyivx_session_cloneownership/lifecycle note in FFI docsLanded via nested PR because enterprise ruleset blocks direct pushes to
spiceai-*.Test plan